You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2017/12/28 10:25:39 UTC

[GitHub] rhtyd commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

rhtyd commented on a change in pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#discussion_r158924899
 
 

 ##########
 File path: tools/marvin/marvin/config/test_data.py
 ##########
 @@ -419,8 +419,8 @@
         "displaytext": "MySharedOffering",
         "guestiptype": "Shared",
         "supportedservices": "Dhcp,Dns,UserData",
-        "specifyVlan": "True",
-        "specifyIpRanges": "True",
+        "specifyVlan": "False",
 
 Review comment:
   @fmaximus This test data is in use by several test cases, changing the values from 'true' to 'false' may cause regressions. Can you change them back, and in your tests perhaps change the value to False if necessary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services