You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "07-Chandra (via GitHub)" <gi...@apache.org> on 2023/10/13 18:45:12 UTC
[PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
07-Chandra opened a new pull request, #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657
## What does this Pull Request do ?
i Fixed Break point issue of home, from 551px to 695px screen size which was breaking earlier but now working good.
Fixes #369
##Types of change
I modified certain fixed pixel sizes to expand to full width when the screen size is smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "07-Chandra (via GitHub)" <gi...@apache.org>.
07-Chandra commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1767552737
please check now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1763606047
Hi @07-Chandra thank you for your pr. Can you remove content about the code format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "07-Chandra (via GitHub)" <gi...@apache.org>.
07-Chandra commented on code in PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#discussion_r1363027315
##########
src/components/Sections/HomepageHeader.tsx:
##########
@@ -15,177 +15,188 @@ import ScarfIcon from "@site/static/img/Homepage/brand/Scarf.svg";
import IBMIcon from "@site/static/img/Homepage/brand/IBM.svg";
export function HomepageHeader() {
- return (
- <div>
- <img
- src={HeaderBG}
- alt=""
- className="
- absolute top-[0px] left-[0px] max-h-[580px]
- xl:w-screen sm:hidden"
- />
- <img
- src={HeaderBGMB}
- alt=""
- className="
- absolute top-[0px] left-[0px] w-screen z-0
- sm:h-[496px] mobile:h-[526px]
- hidden sm:block"
- />
- <header
- className="
- flex justify-center
- items-center
- w-[840px] mobile:w-[90%] sm:w-[600px] 2xl:w-[1000px]
- mobile:mt-[32px] sm:mt-[65px] mt-[71px]
- z-10
- mx-auto
- "
- >
- <div
- className="z-10
- flex flex-col
- flex-wrap
- "
- >
- <div
- className="text-primary
- font-bold font-inter
- text-label40 sm:text-heading2 mobile:text-label20
- sm:font-semibold"
- >
- Debug engineering processes and discover opportunities with DORA, Community Growth, Engineering Throughput and more DevLake dashboards...
- </div>
- <div
+ return (
+ <div className="w-full">
+ <img
+ src={HeaderBG}
+ alt=""
+ className="
+ absolute top-[0px] left-[0px] max-h-[580px]
+ xl:w-screen sm:hidden"
+ />
+ <img
+ src={HeaderBGMB}
+ alt=""
+ className="
+ absolute top-[0px] left-[0px] w-screen z-0
+ sm:h-[496px] mobile:h-[526px]
+ hidden sm:block"
+ />
+ <header
className="
- mt-5 mobile:mt-3 sm:mt-3
- text-primary-800
- text-label24
- sm:text-label16Lake mobile:text-label16Lake
- font-inter
- "
+ flex justify-center
+ items-center
+ w-[840px] mobile:w-[90%] sm:w-full 2xl:w-[1000px] custom-padding
+ mobile:mt-[32px] sm:mt-[65px] mt-[71px]
+ z-10
+ mx-auto
+ "
>
- Apache DevLake™ (Incubating) ingests, analyzes, and visualizes the
- fragmented data from DevOps tools to distill insights for
- engineering excellence.
- </div>
+ <div
+ className="z-10
+ flex flex-col
+ flex-wrap
+ "
+ >
+ <div
+ className="text-primary
+ font-bold font-inter
+ text-label40 sm:text-heading2 mobile:text-label20
+ sm:font-semibold"
+ >
+ Debug engineering processes and discover opportunities with DORA, Community Growth, Engineering Throughput and more DevLake dashboards...
+ </div>
+ <div
+ className="
+ mt-5 mobile:mt-3 sm:mt-3
+ text-primary-800
+ text-label24
+ sm:text-label16Lake mobile:text-label16Lake
+ font-inter
+ "
+ >
+ Apache DevLake™ (Incubating) ingests, analyzes, and visualizes the
+ fragmented data from DevOps tools to distill insights for
+ engineering excellence.
+ </div>
+ <div className="
+ flex
+ mobile:flex-col
+ mt-[48px] sm:mt-3
+ items-center
+ justify-between
+ mb-[129px] 2xl:mb-[148px] sm:mb-[101px] mobile:mb-[44.9px]
+ ">
+ <Link
+ className="primary-button
+ flex
+ whitespace-nowrap
+ mobile:mt-3
+ rounded-[8px] sm:rounded-[5px] mobile:rounded-[5px]
+ w-[200px] sm:w-[140px] mobile:w-[140px]
+ h-[48px] sm:h-[32px] mobile:h-[32px]"
+ to="https://devlake.apache.org/livedemo/EngineeringLeads/DORA"
+ >
+ See it Live
+ </Link>
+ <Link
+ className="primary-button
+ flex
+ whitespace-nowrap
+ rounded-[8px] sm:rounded-[5px] mobile:rounded-[5px]
+ bg-neutral-invert
+ text-primary-500
+ border-2 border-primary-500 border-solid
+ hover:text-primary-500
+ hover:bg-neutral-invert
+ hover:opacity-80
+ mobile:mt-3
+ w-[200px] sm:w-[140px] mobile:w-[140px]
+ h-[48px] sm:h-[32px] mobile:h-[32px]"
+ to="https://devlake.apache.org/docs/GettingStarted"
+ >
+ Install DevLake
+ </Link>
+ <Link
+ className="primary-button
+ flex
+ whitespace-nowrap
+ rounded-[8px] sm:rounded-[5px] mobile:rounded-[5px]
+
+
+
+
+
+
+
+ Expand All
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "07-Chandra (via GitHub)" <gi...@apache.org>.
07-Chandra commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1766566996
i think, now i have solved issues and changed content formation.
please review my new commit Chnages.
if you see steel any issue please let me know, i will work on those part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#discussion_r1363397010
##########
src/components/Sections/HomepageHeader.tsx:
##########
@@ -15,177 +15,177 @@ import ScarfIcon from "@site/static/img/Homepage/brand/Scarf.svg";
import IBMIcon from "@site/static/img/Homepage/brand/IBM.svg";
export function HomepageHeader() {
- return (
- <div>
- <img
- src={HeaderBG}
- alt=""
- className="
- absolute top-[0px] left-[0px] max-h-[580px]
- xl:w-screen sm:hidden"
- />
- <img
- src={HeaderBGMB}
- alt=""
- className="
- absolute top-[0px] left-[0px] w-screen z-0
- sm:h-[496px] mobile:h-[526px]
- hidden sm:block"
- />
- <header
- className="
- flex justify-center
- items-center
- w-[840px] mobile:w-[90%] sm:w-[600px] 2xl:w-[1000px]
- mobile:mt-[32px] sm:mt-[65px] mt-[71px]
- z-10
- mx-auto
- "
- >
- <div
- className="z-10
- flex flex-col
- flex-wrap
- "
- >
- <div
- className="text-primary
- font-bold font-inter
- text-label40 sm:text-heading2 mobile:text-label20
- sm:font-semibold"
- >
- Debug engineering processes and discover opportunities with DORA, Community Growth, Engineering Throughput and more DevLake dashboards...
- </div>
- <div
+ return (
+ <div className="w-full">
+ <img
Review Comment:
Hi, @07-Chandra, I understand you only modified `w-full`, but there are still many additional changes in this file, can you remove these? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1833560800
Hi @07-Chandra , can you update the PR so that we can get it merged? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky closed pull request #657: Fixed Break point issue of home, from 551px to 695px screen size.
URL: https://github.com/apache/incubator-devlake-website/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1765884755
Hi, @07-Chandra We are very sorry for the trouble caused to you because our repo does not have a formatting tool. We also don’t want to include unnecessary content in a PR, as shown in the screenshot below. The automatic formatting of your editor may cause it, so can you please remove modifications like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#discussion_r1362973974
##########
src/components/Sections/HomepageHeader.tsx:
##########
@@ -15,177 +15,188 @@ import ScarfIcon from "@site/static/img/Homepage/brand/Scarf.svg";
import IBMIcon from "@site/static/img/Homepage/brand/IBM.svg";
export function HomepageHeader() {
- return (
- <div>
- <img
- src={HeaderBG}
- alt=""
- className="
- absolute top-[0px] left-[0px] max-h-[580px]
- xl:w-screen sm:hidden"
- />
- <img
- src={HeaderBGMB}
- alt=""
- className="
- absolute top-[0px] left-[0px] w-screen z-0
- sm:h-[496px] mobile:h-[526px]
- hidden sm:block"
- />
- <header
- className="
- flex justify-center
- items-center
- w-[840px] mobile:w-[90%] sm:w-[600px] 2xl:w-[1000px]
- mobile:mt-[32px] sm:mt-[65px] mt-[71px]
- z-10
- mx-auto
- "
- >
- <div
- className="z-10
- flex flex-col
- flex-wrap
- "
- >
- <div
- className="text-primary
- font-bold font-inter
- text-label40 sm:text-heading2 mobile:text-label20
- sm:font-semibold"
- >
- Debug engineering processes and discover opportunities with DORA, Community Growth, Engineering Throughput and more DevLake dashboards...
- </div>
- <div
+ return (
+ <div className="w-full">
+ <img
+ src={HeaderBG}
+ alt=""
+ className="
+ absolute top-[0px] left-[0px] max-h-[580px]
+ xl:w-screen sm:hidden"
+ />
+ <img
+ src={HeaderBGMB}
+ alt=""
+ className="
+ absolute top-[0px] left-[0px] w-screen z-0
+ sm:h-[496px] mobile:h-[526px]
+ hidden sm:block"
+ />
+ <header
className="
- mt-5 mobile:mt-3 sm:mt-3
- text-primary-800
- text-label24
- sm:text-label16Lake mobile:text-label16Lake
- font-inter
- "
+ flex justify-center
+ items-center
+ w-[840px] mobile:w-[90%] sm:w-full 2xl:w-[1000px] custom-padding
+ mobile:mt-[32px] sm:mt-[65px] mt-[71px]
+ z-10
+ mx-auto
+ "
>
- Apache DevLake™ (Incubating) ingests, analyzes, and visualizes the
- fragmented data from DevOps tools to distill insights for
- engineering excellence.
- </div>
+ <div
+ className="z-10
+ flex flex-col
+ flex-wrap
+ "
+ >
+ <div
+ className="text-primary
+ font-bold font-inter
+ text-label40 sm:text-heading2 mobile:text-label20
+ sm:font-semibold"
+ >
+ Debug engineering processes and discover opportunities with DORA, Community Growth, Engineering Throughput and more DevLake dashboards...
+ </div>
+ <div
+ className="
+ mt-5 mobile:mt-3 sm:mt-3
+ text-primary-800
+ text-label24
+ sm:text-label16Lake mobile:text-label16Lake
+ font-inter
+ "
+ >
+ Apache DevLake™ (Incubating) ingests, analyzes, and visualizes the
+ fragmented data from DevOps tools to distill insights for
+ engineering excellence.
+ </div>
+ <div className="
+ flex
+ mobile:flex-col
+ mt-[48px] sm:mt-3
+ items-center
+ justify-between
+ mb-[129px] 2xl:mb-[148px] sm:mb-[101px] mobile:mb-[44.9px]
+ ">
+ <Link
+ className="primary-button
+ flex
+ whitespace-nowrap
+ mobile:mt-3
+ rounded-[8px] sm:rounded-[5px] mobile:rounded-[5px]
+ w-[200px] sm:w-[140px] mobile:w-[140px]
+ h-[48px] sm:h-[32px] mobile:h-[32px]"
+ to="https://devlake.apache.org/livedemo/EngineeringLeads/DORA"
+ >
+ See it Live
+ </Link>
+ <Link
+ className="primary-button
+ flex
+ whitespace-nowrap
+ rounded-[8px] sm:rounded-[5px] mobile:rounded-[5px]
+ bg-neutral-invert
+ text-primary-500
+ border-2 border-primary-500 border-solid
+ hover:text-primary-500
+ hover:bg-neutral-invert
+ hover:opacity-80
+ mobile:mt-3
+ w-[200px] sm:w-[140px] mobile:w-[140px]
+ h-[48px] sm:h-[32px] mobile:h-[32px]"
+ to="https://devlake.apache.org/docs/GettingStarted"
+ >
+ Install DevLake
+ </Link>
+ <Link
+ className="primary-button
+ flex
+ whitespace-nowrap
+ rounded-[8px] sm:rounded-[5px] mobile:rounded-[5px]
+
+
+
+
+
+
+
+ Expand All
Review Comment:
Sorry @07-Chandra, can you check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "07-Chandra (via GitHub)" <gi...@apache.org>.
07-Chandra commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1765961397
thank you, i will modify codes and will send new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed Break point issue of home, from 551px to 695px screen size. [incubator-devlake-website]
Posted by "07-Chandra (via GitHub)" <gi...@apache.org>.
07-Chandra commented on PR #657:
URL: https://github.com/apache/incubator-devlake-website/pull/657#issuecomment-1765830299
i'm newbie to the contribution and not able to understand error- "merging is blocked" and about content about the code format . can you elaborate more ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org