You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/04 08:27:08 UTC

[GitHub] [spark] WeichenXu123 opened a new pull request #31004: [MINOR] Improve flaky NaiveBayes test

WeichenXu123 opened a new pull request #31004:
URL: https://github.com/apache/spark/pull/31004


   ### What changes were proposed in this pull request?
   Improve flaky NaiveBayes test
   
   Current test may sometimes fail under different BLAS library. Due to some absTol check. Error like
   ```
   Expected 0.7 and 0.6485507246376814 to be within 0.05 using absolute tolerance.&#010;validateModelFit:&#010; piData: [-0.6931471805599453, -2.3025850929940455, -0.916290731874155]&#010; thetaData: [-0.35667494393873245, -2.3025850929940455, -2.3025850929940455, -2.3025850929940455]&#010;[-2.3025850929940455, -0.35667494393873245, -2.3025850929940455, -2.3025850929940455]&#010;[-2.3025850929940455, -2.3025850929940455, -0.35667494393873245, -2.3025850929940455]&#010; model.labels: [0.0, 1.0, 2.0]&#010; model.pi: [-0.7665651538362903, -2.201220586649602, -0.856311441692565]&#010; model.theta: [-0.37395145030557764, -2.3207989529680315, -2.228876242777372, -2.2429468266743147]&#010;[-1.90074975293646, -0.43301505987639466, -2.3915747099957807, -2.2026741821037836]&#010;[-2.2575407135939427, -2.315360284482769, -0.3519176566658153, -2.371678715072992]
   
   ```
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757630825






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] WeichenXu123 closed pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
WeichenXu123 closed pull request #31004:
URL: https://github.com/apache/spark/pull/31004


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757622028


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38493/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757619252


   **[Test build #133904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133904/testReport)** for PR 31004 at commit [`09d5b96`](https://github.com/apache/spark/commit/09d5b96548eb332ba518e20073d844dec7b149dd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757612311


   Merged to master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757606075


   **[Test build #133904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133904/testReport)** for PR 31004 at commit [`09d5b96`](https://github.com/apache/spark/commit/09d5b96548eb332ba518e20073d844dec7b149dd).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757630825






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757614898


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38493/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #31004:
URL: https://github.com/apache/spark/pull/31004


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757606075


   **[Test build #133904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133904/testReport)** for PR 31004 at commit [`09d5b96`](https://github.com/apache/spark/commit/09d5b96548eb332ba518e20073d844dec7b149dd).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #31004: [MINOR] Improve flaky NaiveBayes test

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31004:
URL: https://github.com/apache/spark/pull/31004#issuecomment-757608233


   LGTM pending tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org