You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/04 13:29:00 UTC

[jira] [Commented] (PARQUET-1462) Allow specifying new development version in prepare-release.sh

    [ https://issues.apache.org/jira/browse/PARQUET-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708700#comment-16708700 ] 

ASF GitHub Bot commented on PARQUET-1462:
-----------------------------------------

zivanfi closed pull request #557: PARQUET-1462: Allow specifying new development version in prepare-release.sh
URL: https://github.com/apache/parquet-mr/pull/557
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dev/prepare-release.sh b/dev/prepare-release.sh
old mode 100644
new mode 100755
index 1ced001f8..04a79a159
--- a/dev/prepare-release.sh
+++ b/dev/prepare-release.sh
@@ -18,16 +18,22 @@
 # under the License.
 #
 
-if [ -z "$1" ]; then
-  echo "Usage: $0 <version>"
-  exit
+set -e
+
+if [ -z "$2" ]; then
+    cat <<EOF
+Usage: $0 <release-version> <new-development-version-without-SNAPSHOT-suffix>
+Example: $0 1.6.0 1.7.0
+EOF
+  exit 1
 fi
 
-version=$1
+release_version="$1"
+new_development_version="$2-SNAPSHOT"
 
-tag=apache-parquet-$version
+tag="apache-parquet-$release_version"
 
 mvn release:clean
-mvn release:prepare -Dtag=$tag -DreleaseVersion=$version
+mvn release:prepare -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version"
 
 echo "Finish staging binary artifacts by running: mvn release:perform"


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow specifying new development version in prepare-release.sh
> --------------------------------------------------------------
>
>                 Key: PARQUET-1462
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1462
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-format, parquet-mr
>            Reporter: Zoltan Ivanfi
>            Assignee: Zoltan Ivanfi
>            Priority: Major
>              Labels: pull-request-available
>
> Currently prepare-release.sh only takes the release version as a parameter, the new development version is asked interactively for each individual pom.xml file, which makes answering them tedious.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)