You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by "Eli Reisman (JIRA)" <ji...@apache.org> on 2013/02/22 21:42:12 UTC

[jira] [Commented] (GIRAPH-530) GiraphInputFormat#getSplits() should be aware of multithreaded input

    [ https://issues.apache.org/jira/browse/GIRAPH-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584662#comment-13584662 ] 

Eli Reisman commented on GIRAPH-530:
------------------------------------

This makes a lot of sense, and again is more reason that there's simple but important things left to nail down before a release can occur.
                
> GiraphInputFormat#getSplits() should be aware of multithreaded input
> --------------------------------------------------------------------
>
>                 Key: GIRAPH-530
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-530
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>
> The current signature of getSplits() assumes that the only piece of information needed in order to determine the number of splits is the number of workers.
> With multiple input threads for each worker, this is no longer the case.
> We could solve this very simply by renaming the numWorkers parameter to something like minSplitCountHint, and changing any existing callers to pass the total number of input threads instead of workers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira