You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/04/17 11:24:00 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
fynmanoj opened a new pull request #1702:
URL: https://github.com/apache/fineract/pull/1702
## Description
https://issues.apache.org/jira/browse/FINERACT-1348
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1702:
URL: https://github.com/apache/fineract/pull/1702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on a change in pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on a change in pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#discussion_r726004867
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -1622,6 +1627,13 @@ public void updateLoanSummarAndStatus() {
this.fixedEmiAmount = null;
}
+ if (command.isChangeInBigDecimalParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName,
+ this.fixedPrincipalPercentagePerInstallment)) {
+ this.fixedPrincipalPercentagePerInstallment = command
+ .bigDecimalValueOfParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName);
+ actualChanges.put(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName, this.fixedEmiAmount);
+ }
Review comment:
@fynmanoj : Can you confirm this and rebase it again? Rest of it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a change in pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
ptuomola commented on a change in pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#discussion_r713102508
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -1622,6 +1627,13 @@ public void updateLoanSummarAndStatus() {
this.fixedEmiAmount = null;
}
+ if (command.isChangeInBigDecimalParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName,
+ this.fixedPrincipalPercentagePerInstallment)) {
+ this.fixedPrincipalPercentagePerInstallment = command
+ .bigDecimalValueOfParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName);
+ actualChanges.put(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName, this.fixedEmiAmount);
+ }
Review comment:
Shouldn't this be this.fixedPrincipalPercentagePerInstallment, not this.fixedEmiAmount?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#issuecomment-916950100
Hi @fynmanoj Sorry for the delay. There are now merge conflicts on the PR.
@francisguchie , @bharathc27 you can test this function together with the UI changes found here: https://github.com/openMF/community-app/pull/3381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1702:
URL: https://github.com/apache/fineract/pull/1702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#issuecomment-950126065
Please lets make it a habit not to merge PRs when Travis Tests have not passed. Can you close the corresponding issue on JIRA please...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#issuecomment-854294822
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#issuecomment-854294822
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on a change in pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on a change in pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#discussion_r726048104
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -1622,6 +1627,13 @@ public void updateLoanSummarAndStatus() {
this.fixedEmiAmount = null;
}
+ if (command.isChangeInBigDecimalParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName,
+ this.fixedPrincipalPercentagePerInstallment)) {
+ this.fixedPrincipalPercentagePerInstallment = command
+ .bigDecimalValueOfParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName);
+ actualChanges.put(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName, this.fixedEmiAmount);
+ }
Review comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#issuecomment-916953955
@awasum , I have rebased the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1702: FIneract-1348-balloon-payment-fixed-principal-percentage
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1702:
URL: https://github.com/apache/fineract/pull/1702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org