You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:24:15 UTC

[GitHub] [helix] dasahcc commented on a change in pull request #1041: Change the error message to be meaningful naming

dasahcc commented on a change in pull request #1041:
URL: https://github.com/apache/helix/pull/1041#discussion_r433409214



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/json/instance/StoppableCheck.java
##########
@@ -30,8 +30,8 @@
   // Category to differentiate which step the check fails
   public enum Category {
     HELIX_OWN_CHECK("Helix:"),
-    CUSTOM_INSTANCE_CHECK("CustomInstance:"),
-    CUSTOM_PARTITION_CHECK("CustomPartition:");
+    CUSTOM_INSTANCE_CHECK("CustomInstanceHealthFailure:"),
+    CUSTOM_PARTITION_CHECK("CustomPartitionHealthFailure:");

Review comment:
       Good suggestion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org