You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/11/02 07:34:38 UTC
[GitHub] carbondata pull request #2892: [CARBONDATA-3069][Compaction] Fix bugs in set...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2892
[CARBONDATA-3069][Compaction] Fix bugs in setting cores for compaction
Current implementation for setting cores for compaction is wrong. It
will set the cores first and then set the flow to compaction, which
causes that the number set is always from 'loading.cores' instead of
'compaction.cores'.
In this commit, we fix this bug by setting the cores again when the user
changes the flow to compaction.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`Yes, only internal used interfaces has been changed`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`No, it only affects the intermediate procedure`
- How it is tested? Please attach test report.
`Tested and verified in local machine`
- Is it a performance related change? Please attach the performance test report.
`For users whose 'compaction.cores' is not equal to 'loading.cores', the performance of compaction may change`
- Any additional information to help reviewers in testing this change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 181102_bug_compaction_cores
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2892
----
commit 5176fe73c6c4c23603a05c0b32cd9170d447714b
Author: xuchuanyin <xu...@...>
Date: 2018-11-02T07:24:57Z
Fix bugs in setting cores for compaction
Current implementation for setting cores for compaction is wrong. It
will set the cores first and then set the flow to compaction, which
causes that the number set is always from 'loading.cores' instead of
'compaction.cores'.
In this commit, we fix this bug by setting the cores again when the user
changes the flow to compaction.
----
---
[GitHub] carbondata issue #2892: [CARBONDATA-3069][Compaction] Fix bugs in setting co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2892
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1234/
---
[GitHub] carbondata issue #2892: [CARBONDATA-3069][Compaction] Fix bugs in setting co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2892
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1449/
---
[GitHub] carbondata pull request #2892: [CARBONDATA-3069][Compaction] Fix bugs in set...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2892
---
[GitHub] carbondata issue #2892: [CARBONDATA-3069][Compaction] Fix bugs in setting co...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2892
LGTM
---
[GitHub] carbondata issue #2892: [CARBONDATA-3069][Compaction] Fix bugs in setting co...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2892
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9498/
---
[GitHub] carbondata issue #2892: [CARBONDATA-3069][Compaction] Fix bugs in setting co...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2892
LGTM
---