You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org> on 2018/05/21 21:42:00 UTC
[jira] [Commented] (IO-577) Add readers to filter out given
characters
[ https://issues.apache.org/jira/browse/IO-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483101#comment-16483101 ]
Bruno P. Kinoshita commented on IO-577:
---------------------------------------
Looks good! Some comments:
* In CharacterSetFilterReader, maybe remove private static final HashSet<Integer> EMPTY_SET = new HashSet<>(0); ? And perhaps use Collections.emptySet() ?
* Also in CharacterSetFilterReader, I think it could be dangerous just using the collection provided by the user. Maybe create a new field using Collections.unmodifiableSet(originalSet) ?
Other than that, +1
> Add readers to filter out given characters
> ------------------------------------------
>
> Key: IO-577
> URL: https://issues.apache.org/jira/browse/IO-577
> Project: Commons IO
> Issue Type: New Feature
> Components: Filters
> Reporter: Gary Gregory
> Priority: Major
> Attachments: commons-io-577.patch
>
>
> Add readers to filter out given characters, handy to remove known junk characters from CSV files for example. Please see attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)