[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1041: MINIFICPP-1358 Add SendBody property functionality to InvokeHTTP processor

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1041:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1041#discussion_r611537295



##########
File path: PROCESSORS.md
##########
@@ -684,15 +684,17 @@ In the list below, the names of required properties appear in bold. Any other pr
 |Disable Peer Verification|false||Disables peer verification for the SSL session|
 |HTTP Method|GET||HTTP request method (GET, POST, PUT, PATCH, DELETE, HEAD, OPTIONS). Arbitrary methods are also supported. Methods other than POST, PUT and PATCH will be sent without a message body.|
 |Include Date Header|true||Include an RFC-2616 Date header in the request.|
+|invokehttp-proxy-password|||Password to set when authenticating against proxy|
+|invokehttp-proxy-username|||Username to set when authenticating against proxy|
+|Penalize on "No Retry"|false||Enabling this property will penalize FlowFiles that are routed to the "No Retry" relationship.|
 |Proxy Host|||The fully qualified hostname or IP address of the proxy server|
 |Proxy Port|||The port of the proxy server|
+|Put Response Body in Attribute|||If set, the response body received back will be put into an attribute of the original FlowFile instead of a separate FlowFile. The attribute key to put to is determined by evaluating value of this property.|
 |Read Timeout|15 secs||Max wait time for response from remote service.|
 |Remote URL|||Remote URL which will be connected to, including scheme, host, port, path.<br/>**Supports Expression Language: true**|
+|send-message-body|true||If true, sends the HTTP message body on POST/PUT/PATCH requests (default).  If false, suppresses the message body and content-type header for these requests.|

Review comment:
       I would prefer to have the version with the capitals and spaces here and in the config, since this is facing the user and most of our properties are like that.

##########
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##########
@@ -95,9 +95,12 @@ core::Property InvokeHTTP::ContentType("Content-type", "The Content-Type to spec
                                        "POST or PATCH. In the case of an empty value after evaluating an expression language expression, "
                                        "Content-Type defaults to",
                                        "application/octet-stream");
-core::Property InvokeHTTP::SendBody("send-message-body", "If true, sends the HTTP message body on POST/PUT/PATCH requests (default).  "
-                                    "If false, suppresses the message body and content-type header for these requests.",
-                                    "true");
+core::Property InvokeHTTP::SendBody(
+    core::PropertyBuilder::createProperty("send-message-body", "Send Body")

Review comment:
       NiFi has a similar property called "Send Message Body". I would rename this to match.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org