You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2005/12/20 18:10:42 UTC
svn commit: r358040 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c
Author: wrowe
Date: Tue Dec 20 09:10:38 2005
New Revision: 358040
URL: http://svn.apache.org/viewcvs?rev=358040&view=rev
Log:
This shift was treated in 32 bit scope, then masked to 64 bits,
which was probably quite uncool.
Modified:
httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c
Modified: httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c?rev=358040&r1=358039&r2=358040&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c Tue Dec 20 09:10:38 2005
@@ -576,7 +576,7 @@
/* Loop through the requirements array until there's no elements
* left, or something causes a return from inside the loop */
for(x=0; x < reqs_arr->nelts; x++) {
- if (! (reqs[x].method_mask & (1 << m))) {
+ if (! (reqs[x].method_mask & (APR_INT64_C(1) << m))) {
continue;
}
method_restricted = 1;
Re: svn commit: r358040 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c
Posted by Joe Orton <jo...@redhat.com>.
On Tue, Dec 20, 2005 at 05:10:42PM -0000, William Rowe wrote:
> --- httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c (original)
> +++ httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c Tue Dec 20 09:10:38 2005
> @@ -576,7 +576,7 @@
> /* Loop through the requirements array until there's no elements
> * left, or something causes a return from inside the loop */
> for(x=0; x < reqs_arr->nelts; x++) {
> - if (! (reqs[x].method_mask & (1 << m))) {
> + if (! (reqs[x].method_mask & (APR_INT64_C(1) << m))) {
Should really use the AP_METHOD_BIT constant.