You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/09/28 05:24:05 UTC
[Bug 121134] New: Aoo crashes while opening the MS Word document
https://issues.apache.org/ooo/show_bug.cgi?id=121134
Priority: P2
Bug ID: 121134
Assignee: ooo-issues@incubator.apache.org
Summary: Aoo crashes while opening the MS Word document
Severity: major
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: wujinlong@gmail.com
Hardware: All
Status: UNCONFIRMED
Version: AOO350-dev
Component: code
Product: word processor
Created attachment 79668
--> https://issues.apache.org/ooo/attachment.cgi?id=79668&action=edit
Test document
When opening the test MS Word document (attached), Aoo crashes.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from zhang jianfang <zh...@apache.org> ---
The analysis is clear enough and I think it is acceptable to fallback to old
logic when the AbstractNum can not be found.
delivered the code and mark the bug as resolved.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
--- Comment #3 from SVN Robot <sv...@dev.null.org> ---
"zhangjf" committed SVN revision 1402153 into trunk:
#i121134#, more fix for i119657, fallback to old logic to use current
Abstrac...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
Li Feng Wang <ph...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |phoenix.wanglf@gmail.com
--- Comment #6 from Li Feng Wang <ph...@gmail.com> ---
Verified pass on trunk r1404513.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |AOO 4.0
--- Comment #7 from hdu@apache.org <hd...@apache.org> ---
Updated target to release that will contain the fix.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lilinyi921734@gmail.com
--- Comment #5 from zhang jianfang <zh...@apache.org> ---
*** Bug 121199 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
Li Feng Wang <ph...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|VERIFIED |CLOSED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
wujinlong@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79671| |review?
Flags| |
--- Comment #1 from wujinlong@gmail.com ---
Created attachment 79671
--> https://issues.apache.org/ooo/attachment.cgi?id=79671&action=edit
Patch
The crash is related with fix for bug 119657. There is a bug in the solution.
If revert the fix, Aoo will not crash.
In the test document, there is a special case not covered. The "AbstractNum id
0" has a style link to style "MinDList", which references "Num id 8". At the
same time, "AbstractNum id 0" has a complete level definition.
When processing "num id 1", it finds that the AbstractNum it points to, which
is "AbstractNum id 0", has a style linked. Then it will use the style name to
find the Num it uses, which is "Num id 8". Since the Num is processed in
sequence, "Num id 8" is not processed at that moment. So it will fail to
retrieve the AbstractNum "Num id 8" uses, which should be "AbstractNum id 0".
According to the logic of fix for 119657, in such case, the "AbstractNum id 0"
would not be created successfully. In fact, we should create the number rule
using the level definitions defined in "AbstractNum id 0", rather than look for
the style link.
The above explains the bug in previous solution, however the reason why the Aoo
crashes is not clear. I've tried to attach the soffice process, when Aoo
crashes, the Visual Studio can't show any meaningful call stack to determine
where Aoo crashes.
But if I add two lines of code to the previous fix, Aoo will not crash. So I
suppose the crash is related with unsuccessful creation of Number rule for
"AbstractNum id 0".
This new fix is to return the current AbstractNum if can't find a correct
AbstractNum through style link, which gos the same path as previous (without
the previous fix).
-------------- numbering.xml -------------
<w:abstractNum w:abstractNumId="0">
<w:nsid w:val="22A540F9"/>
<w:multiLevelType w:val="multilevel"/>
<w:tmpl w:val="22AC870E"/>
<w:styleLink w:val="MinDList"/>
<w:lvl w:ilvl="0">
......
</w:abstractNum>
......
<w:num w:numId="1">
<w:abstractNumId w:val="0"/>
</w:num>
......
<w:num w:numId="8">
<w:abstractNumId w:val="0"/>
</w:num>
---------------------------------
------- style.xml------
<w:style w:type="numbering" w:customStyle="1" w:styleId="MinDList">
<w:name w:val="MinD List"/>
<w:rsid w:val="00E278DA"/>
<w:pPr>
<w:numPr>
<w:numId w:val="8"/>
</w:numPr>
</w:pPr>
</w:style>
------------------------
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 121134] Aoo crashes while opening the MS Word document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121134
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |zhangjf@apache.org
Ever confirmed|0 |1
--- Comment #2 from zhang jianfang <zh...@apache.org> ---
Mark as confirmed.
--
You are receiving this mail because:
You are the assignee for the bug.