You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/08 15:12:20 UTC

[jira] [Commented] (FLINK-4032) Replace all usage of Guava Preconditions

    [ https://issues.apache.org/jira/browse/FLINK-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320716#comment-15320716 ] 

ASF GitHub Bot commented on FLINK-4032:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2084

    [FLINK-4032] Replace all usages Guava preconditions

    This PR replaces every usage of the Guava Preconditions in Flink with our own Preconditions class.
    
    In addition, 
    - the guava dependency was completely removed from the RabbitMQ connector
    - a checkstyle rules was added preventing further use of guava preconditions

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink guava

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2084.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2084
    
----
commit 7bc5099e0fa7731b5fd8ab7d4a32e29c60468bc6
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:01:19Z

    Remove guava dependency from flink-...-rabbitmq

commit 3f30f1f6bdd98b27ff815fbc56d8c9704e1091a6
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:01:49Z

    Replace Preconditions usage in flink-..-elasticsearch2

commit 8e90a16ef75ed4adcd00261b326aa10f04f5ddac
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:25:26Z

    Replace Preconditions usage in flink-table

commit cf61152d703abec9e2a47ecc102d2b148c172add
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:25:34Z

    Replace Preconditions usage in flink-optimizer

commit b6e90150d3dda1b2cd2822e3031a604798f6dcaf
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:25:45Z

    Replace Preconditions usage in flink-runtime-web

commit 910bf63778ba0a0b1b2ec183c66c524c3dd53ffc
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:25:54Z

    Replace Preconditions usage in flink-scala

commit 9012b1dae48ef9aed50e6e2d9f8bd9c59c8abd80
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:25:58Z

    Replace Preconditions usage in flink-yarn

commit 393da586a8ebcbca60d60b958aa21040ae5197d8
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:26:02Z

    Replace Preconditions usage in flink-tests

commit 90723bf1defcd7baf72285b81c4c5732c8a25624
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:26:13Z

    Replace Preconditions usage in flink-streaming-java

commit 5b27a648d363c1130fbff829c00a298b728d0ae7
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:26:25Z

    Replace Preconditions usage in flink-runtime

commit c5ac8b21591e08ce74865d04baeffc344ad7867c
Author: zentol <ch...@apache.org>
Date:   2016-06-08T14:32:20Z

    checkstyle rule

----


> Replace all usage of Guava Preconditions
> ----------------------------------------
>
>                 Key: FLINK-4032
>                 URL: https://issues.apache.org/jira/browse/FLINK-4032
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)