[GitHub] [shardingsphere] soulasuna commented on a diff in pull request #19876: Refactor lock basic framework in mode

[GitBox <gi...@apache.org>]

soulasuna commented on code in PR #19876:
URL: https://github.com/apache/shardingsphere/pull/19876#discussion_r938408913


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/lock/LockContext.java:
##########
@@ -51,17 +44,17 @@ default void initLockState(InstanceContext instanceContext) {
      * Try Lock.
      *
      * @param lockDefinition lock definition
-     * @param timeoutMilliseconds timeout milliseconds
+     * @param timeoutMillis timeout milliseconds
      * @return is locked or not
      */
-    boolean tryLock(LockDefinition lockDefinition, long timeoutMilliseconds);
+    boolean tryLock(LockDefinition lockDefinition, long timeoutMillis);
     
     /**
-     * Release lock.
+     * Un lock.

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org