You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@esme.apache.org by Richard Hirsch <hi...@gmail.com> on 2009/11/23 10:40:15 UTC
Test error for new API2 tests
@Ethan
I just tried to build with the latest patch from 11/19/2009 and there
is a test error:
Test set: org.apache.esme.api.Api2SpecsAsTest
-------------------------------------------------------------------------------
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.093
sec <<< FAILURE!
API2 should Attempt to create session with an invalid token returns
400 response Time elapsed: 0 sec <<< FAILURE!
org.specs.runner.UserError: '200' is not equal to '400'.
I added the API2.scala file, test results, test.scala files) to the
Jira item (https://issues.apache.org/jira/browse/ESME-14) - maybe you
can see what the problem is.
Thanks.
Dick
Re: Test error for new API2 tests
Posted by Richard Hirsch <hi...@gmail.com>.
I changed the pom.xml to allow for test failures and committed all the
code in the patch.
D.
On Mon, Nov 23, 2009 at 2:36 PM, Richard Hirsch <hi...@gmail.com> wrote:
> excellent question. The problem is that the build stops when we have a
> test error.
>
> I'll change our pom.xml "<testFailureIgnore>true</testFailureIgnore>"
> to allow for test failures but we should probably delete this
> parameter again when we get closer to our release.
>
> Or should we only write tests that are succesful and thne them as
> regression tests.
>
> D.
>
>
> On Mon, Nov 23, 2009 at 2:26 PM, Ethan Jewett <es...@gmail.com> wrote:
>> Hi Dick,
>>
>> this is a failure that should be happening. The problem is that the
>> API is returning the wrong response code, so the test fails.
>>
>> Is it ok to have failing specs in the test suite? I think we should
>> encourage this to facilitate test driven development, but if that's
>> not how we're doing things then I'll stop submitting patches with
>> failing test cases.
>>
>> Ethan
>>
>> On Monday, November 23, 2009, Richard Hirsch <hi...@gmail.com> wrote:
>>> @Ethan
>>>
>>> I just tried to build with the latest patch from 11/19/2009 and there
>>> is a test error:
>>>
>>> Test set: org.apache.esme.api.Api2SpecsAsTest
>>> -------------------------------------------------------------------------------
>>> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.093
>>> sec <<< FAILURE!
>>> API2 should Attempt to create session with an invalid token returns
>>> 400 response Time elapsed: 0 sec <<< FAILURE!
>>> org.specs.runner.UserError: '200' is not equal to '400'.
>>>
>>> I added the API2.scala file, test results, test.scala files) to the
>>> Jira item (https://issues.apache.org/jira/browse/ESME-14) - maybe you
>>> can see what the problem is.
>>>
>>> Thanks.
>>>
>>> Dick
>>>
>>
>
Re: Test error for new API2 tests
Posted by Richard Hirsch <hi...@gmail.com>.
excellent question. The problem is that the build stops when we have a
test error.
I'll change our pom.xml "<testFailureIgnore>true</testFailureIgnore>"
to allow for test failures but we should probably delete this
parameter again when we get closer to our release.
Or should we only write tests that are succesful and thne them as
regression tests.
D.
On Mon, Nov 23, 2009 at 2:26 PM, Ethan Jewett <es...@gmail.com> wrote:
> Hi Dick,
>
> this is a failure that should be happening. The problem is that the
> API is returning the wrong response code, so the test fails.
>
> Is it ok to have failing specs in the test suite? I think we should
> encourage this to facilitate test driven development, but if that's
> not how we're doing things then I'll stop submitting patches with
> failing test cases.
>
> Ethan
>
> On Monday, November 23, 2009, Richard Hirsch <hi...@gmail.com> wrote:
>> @Ethan
>>
>> I just tried to build with the latest patch from 11/19/2009 and there
>> is a test error:
>>
>> Test set: org.apache.esme.api.Api2SpecsAsTest
>> -------------------------------------------------------------------------------
>> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.093
>> sec <<< FAILURE!
>> API2 should Attempt to create session with an invalid token returns
>> 400 response Time elapsed: 0 sec <<< FAILURE!
>> org.specs.runner.UserError: '200' is not equal to '400'.
>>
>> I added the API2.scala file, test results, test.scala files) to the
>> Jira item (https://issues.apache.org/jira/browse/ESME-14) - maybe you
>> can see what the problem is.
>>
>> Thanks.
>>
>> Dick
>>
>
Re: Test error for new API2 tests
Posted by Ethan Jewett <es...@gmail.com>.
Hi Dick,
this is a failure that should be happening. The problem is that the
API is returning the wrong response code, so the test fails.
Is it ok to have failing specs in the test suite? I think we should
encourage this to facilitate test driven development, but if that's
not how we're doing things then I'll stop submitting patches with
failing test cases.
Ethan
On Monday, November 23, 2009, Richard Hirsch <hi...@gmail.com> wrote:
> @Ethan
>
> I just tried to build with the latest patch from 11/19/2009 and there
> is a test error:
>
> Test set: org.apache.esme.api.Api2SpecsAsTest
> -------------------------------------------------------------------------------
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.093
> sec <<< FAILURE!
> API2 should Attempt to create session with an invalid token returns
> 400 response Time elapsed: 0 sec <<< FAILURE!
> org.specs.runner.UserError: '200' is not equal to '400'.
>
> I added the API2.scala file, test results, test.scala files) to the
> Jira item (https://issues.apache.org/jira/browse/ESME-14) - maybe you
> can see what the problem is.
>
> Thanks.
>
> Dick
>