(superset) 01/01: chore: properly import expect from chai in cypress-base/cypress/support/e2e.ts

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch expect_chai
in repository https://gitbox.apache.org/repos/asf/superset.git

commit cf56599b4a9a046e60cf0c2aa7f6c69d5dbc32b5
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Jan 14 13:02:34 2025 -0800

    chore: properly import expect from chai in cypress-base/cypress/support/e2e.ts
    
    While working on https://github.com/apache/superset/pull/31590, I noticed that `expect` was not properly imported. It was using it from global for some unknown reason.
---
 superset-frontend/cypress-base/cypress/support/e2e.ts | 1 +
 superset-frontend/cypress-base/package.json           | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/cypress-base/cypress/support/e2e.ts b/superset-frontend/cypress-base/cypress/support/e2e.ts
index 7d17935e36..c1b5f11576 100644
--- a/superset-frontend/cypress-base/cypress/support/e2e.ts
+++ b/superset-frontend/cypress-base/cypress/support/e2e.ts
@@ -19,6 +19,7 @@
 import '@cypress/code-coverage/support';
 import '@applitools/eyes-cypress/commands';
 import failOnConsoleError from 'cypress-fail-on-console-error';
+import { expect } from 'chai';
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
 
diff --git a/superset-frontend/cypress-base/package.json b/superset-frontend/cypress-base/package.json
index e65a346741..9842d103ba 100644
--- a/superset-frontend/cypress-base/package.json
+++ b/superset-frontend/cypress-base/package.json
@@ -20,12 +20,13 @@
     "@cypress/code-coverage": "^3.10.4",
     "@superset-ui/core": "^2.1.0",
     "brace": "^0.11.1",
+    "chai": "^4.5.0",
     "cy-verify-downloads": "^0.2.5",
     "cypress-fail-on-console-error": "^4.0.3",
+    "nanoid": "^5.0.9",
     "querystringify": "^2.2.0",
     "react-dom": "^16.13.0",
-    "rison": "^0.1.1",
-    "nanoid": "^5.0.9"
+    "rison": "^0.1.1"
   },
   "devDependencies": {
     "@types/querystringify": "^2.0.0",