[PR] test(runtime-host): tolerate loaded CI runners in the shutdown-deadline test (#3840) [maka]

["sunheyi6 (via GitHub)" <gi...@apache.org>]

sunheyi6 opened a new pull request, #3844:
URL: https://github.com/apache/maka/pull/3844

   ## Problem
   
   `startup failure preserves its cause when shutdown reaches the active deadline` intermittently fails on CI with `composition close did not begin`. The test arms a real Runtime Host kernel and waits 1s for the composition `close` hook; on loaded CI runners the storage-root resolution → owner acquisition → drain → recover-rejection chain can exceed 1s (observed 1053ms/1080ms), so the timeout fires before the kernel is actually wrong.
   
   ## Change
   
   Raise both `withTimeout` budgets in the test to 5s, matching the loaded-CI-tolerant waits already used elsewhere in this file (e.g. `silently-handshaked ephemeral candidate never drained`, `uncooperative Runtime Host did not exit`). `shutdownGraceMs: 100` is unchanged, so the active-deadline semantics under test are identical.
   
   ## Verification
   
   - Target test passes 3/3 on this machine (the whole test now runs ~1.0–1.7s, which the old 1s budget would have been dangerously close to).
   - Mutation check from the issue's acceptance criteria: with `markCloseEntered()` removed from the `close` hook, the test fails with `composition close did not begin` after the 5s budget — a genuine skip is still detected.
   - `tsc` build of `@maka/runtime-host` passes; biome format reports no changes needed.
   
   Note: 3 unrelated tests in this file fail on my Windows machine (`does not take over a generation-mismatched Host`, `Node and Electron Candidates arbitrate`, `answers an admitted bootstrap with draining after shutdown commits`) — reproduced identically with this change stashed, so they are pre-existing local/environment issues (one shows an `EPERM` rename against the real `%LOCALAPPDATA%\\Maka\\runtime-hosts` profile).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] test(runtime-host): tolerate loaded CI runners in the shutdown-deadline test (#3840) [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han merged PR #3844:
URL: https://github.com/apache/maka/pull/3844


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org