You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/03 03:09:06 UTC
[GitHub] [echarts] plainheart opened a new pull request, #17150: fix(geo): fix `dataToPoint` may not be working in lineGL series.
plainheart opened a new pull request, #17150:
URL: https://github.com/apache/echarts/pull/17150
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fix `dataToPoint` may not be working in `lineGL` series - add back two missing arguments to `projectedToPoint` called in Geo `dataToPoint` function.
### Fixed issues
- #16967
## Details
### Before: What was the problem?
The example `lineGL-ny` can't work since v5.3.0 - All lines collapse to the left top corner.
### After: How is it fixed in this PR?
Add back two missing arguments to `projectedToPoint` called in Geo `dataToPoint` function.
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
Please refer to `test/linesGL-ny-appendData.html`
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
Related PR: #16364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17150: fix(geo): fix `dataToPoint` may not be working in lineGL series.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17150:
URL: https://github.com/apache/echarts/pull/17150#issuecomment-1145561142
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #17150: fix(geo): fix `dataToPoint` may not be working in lineGL series.
Posted by GitBox <gi...@apache.org>.
pissang merged PR #17150:
URL: https://github.com/apache/echarts/pull/17150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17150: fix(geo): fix `dataToPoint` may not be working in lineGL series.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17150:
URL: https://github.com/apache/echarts/pull/17150#issuecomment-1145541140
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org