You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "grundprinzip (via GitHub)" <gi...@apache.org> on 2024/07/05 10:13:32 UTC
[PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
grundprinzip opened a new pull request, #32:
URL: https://github.com/apache/spark-connect-go/pull/32
### What changes were proposed in this pull request?
This PR fixes a number of build issues to make sure that the source code is properly formatted and adheres to the Apache rules for license header requirements.
### Why are the changes needed?
Compliance
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1667479276
##########
spark/client/channel/channel_test.go:
##########
@@ -58,6 +58,7 @@ func TestBasicChannelParsing(t *testing.T) {
assert.ErrorIs(t, err, sparkerrors.InvalidInputError)
cb, err = channel.NewBuilder(goodChannelURL)
+ assert.Nilf(t, err, "Should not have an error for a proper URL")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng merged PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1667477631
##########
cmd/spark-connect-example-spark-session/main.go:
##########
@@ -21,6 +21,8 @@ import (
"flag"
"log"
+ "github.com/apache/spark-connect-go/v35/spark/sql/utils"
Review Comment:
Will fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "mathiasschw-db (via GitHub)" <gi...@apache.org>.
mathiasschw-db commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1666834278
##########
cmd/spark-connect-example-spark-session/main.go:
##########
@@ -21,6 +21,8 @@ import (
"flag"
"log"
+ "github.com/apache/spark-connect-go/v35/spark/sql/utils"
Review Comment:
There should not be spaces between these imports
##########
spark/sql/utils/check.go:
##########
@@ -0,0 +1,25 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package utils
+
+import "fmt"
+
+func WarnOnError(f func() error) {
+ if err := f(); err != nil {
+ fmt.Println("Received error:", err)
Review Comment:
You should not use fmt.Println from within library code. At the very minimum, use a logger but do consider a slightly more general version where you can pass in an error handler (which can then in turn be something that logs
##########
spark/client/channel/channel_test.go:
##########
@@ -58,6 +58,7 @@ func TestBasicChannelParsing(t *testing.T) {
assert.ErrorIs(t, err, sparkerrors.InvalidInputError)
cb, err = channel.NewBuilder(goodChannelURL)
+ assert.Nilf(t, err, "Should not have an error for a proper URL")
Review Comment:
`assert.NoError` is the right one to use here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "mathiasschw-db (via GitHub)" <gi...@apache.org>.
mathiasschw-db commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1667183451
##########
cmd/spark-connect-example-spark-session/main.go:
##########
@@ -21,6 +21,8 @@ import (
"flag"
"log"
+ "github.com/apache/spark-connect-go/v35/spark/sql/utils"
Review Comment:
Apologies for being a bit imprecise. I mean this import and the two below that also not std lib and are from the same library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1666877986
##########
cmd/spark-connect-example-spark-session/main.go:
##########
@@ -21,6 +21,8 @@ import (
"flag"
"log"
+ "github.com/apache/spark-connect-go/v35/spark/sql/utils"
Review Comment:
This comes from the gofumpt rules serparating the std library from external packages
<img width="977" alt="image" src="https://github.com/apache/spark-connect-go/assets/3421/6319551c-587a-4888-a7bf-2a1d81543ce8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48777][BUILD] Properly lint, vet and check for license headers. [spark-connect-go]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1667482553
##########
spark/sql/utils/check.go:
##########
@@ -0,0 +1,25 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package utils
+
+import "fmt"
+
+func WarnOnError(f func() error) {
+ if err := f(); err != nil {
+ fmt.Println("Received error:", err)
Review Comment:
Done, added a callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org