You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/23 16:03:25 UTC

[GitHub] [doris] dataroaring commented on a diff in pull request #11144: [Optimize](page cache): bypass page cache during compaction

dataroaring commented on code in PR #11144:
URL: https://github.com/apache/doris/pull/11144#discussion_r928138557


##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -88,7 +88,7 @@ Status BetaRowsetReader::init(RowsetReaderContext* read_context) {
     // load segments
     RETURN_NOT_OK(SegmentLoader::instance()->load_segments(
             _rowset, &_segment_cache_handle,
-            read_context->reader_type == ReaderType::READER_QUERY));

Review Comment:
   for compaction, reader_type is not READER_QUERY, it does not use cache?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org