You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Dag-Erling Smørgrav <de...@des.no> on 2009/11/30 17:33:42 UTC
Whitespace in svn:author
https://svn.met.no/tseries, server version 1.4.2 (yes, I know, yell at
the met.no IT department, not at me), unknown client version. Compare
revision 100:
r100 | johan.karlsteen@smhi.se | 2009-05-06 13:48:41 +0200 (Wed, 06 May 2009) | 3 lines
to revision 122 by the same author:
r122 | Johan.Karlsteen@smhi.se | 2009-09-28 15:20:20 +0200 (Mon, 28 Sep 2009) | 1 line
I can understand (although I don't particularly like) ignoring but
preserving case differences, but the leading space in rev 122 is...
weird.
Is this (i.e. preserving whitespace in svn:author) intentional? If not,
do more recent versions also preserve whitespace, or do they trim it?
Will a more recent server version trip over this, like my 1.6.6 server
tripped over non-UTF characters in svn:log, or will it take it in
stride, perhaps even trim the extra whitespace before sending the data
to the client?
DES
--
Dag-Erling Smørgrav - des@des.no
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2425593
Please start new threads on the <us...@subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <us...@subversion.apache.org>.
Re: Whitespace in svn:author
Posted by Stefan Sperling <st...@elego.de>.
On Mon, Nov 30, 2009 at 09:42:24PM +0100, Dag-Erling Smørgrav wrote:
> David Shere <ds...@steelerubber.com> writes:
> > I think a bigger question might be why and/or how the server accepted
> > a commit by such a user. I have tried to duplicate your problem by
> > creating users with leading spaces in their name. When I do, my
> > commits (and checkouts) fail with the message
> > "/home/david/tempRepo/conf/passwd:10: Option expected". This problem
> > magically goes away when I remove usernames with leading spaces from
> > the passwd file and restart the server daemon.
>
> Well, a) there is no passwd file - it uses LDAP to authenticate users -
> and b) of course there is no leading space in the LDAP directory; I
> suspect that what happened was that he typed a space before his login
> name when he was asked for authenticatation, and for some reason, the
> client did not strip it and both the Apache LDAP authentication module
> and the Subversion server accepted it. I have no idea what client he
> used, but the server is definitely 1.4.2 (the server runs Debian Etch,
> AFAIK). If I had to guess, I'd say he's probably running Ubuntu Hardy,
> which is the reference platform for the software in that repo, so 1.5.1.
I find it hard to believe that ldap and svn have a bug where additional
spaces around the user name don't cause an authentication failure.
Are you sure this svn:author property not been propedited?
Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2425825
Please start new threads on the <us...@subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <us...@subversion.apache.org>.
Re: Whitespace in svn:author
Posted by Dag-Erling Smørgrav <de...@des.no>.
David Shere <ds...@steelerubber.com> writes:
> I think a bigger question might be why and/or how the server accepted
> a commit by such a user. I have tried to duplicate your problem by
> creating users with leading spaces in their name. When I do, my
> commits (and checkouts) fail with the message
> "/home/david/tempRepo/conf/passwd:10: Option expected". This problem
> magically goes away when I remove usernames with leading spaces from
> the passwd file and restart the server daemon.
Well, a) there is no passwd file - it uses LDAP to authenticate users -
and b) of course there is no leading space in the LDAP directory; I
suspect that what happened was that he typed a space before his login
name when he was asked for authenticatation, and for some reason, the
client did not strip it and both the Apache LDAP authentication module
and the Subversion server accepted it. I have no idea what client he
used, but the server is definitely 1.4.2 (the server runs Debian Etch,
AFAIK). If I had to guess, I'd say he's probably running Ubuntu Hardy,
which is the reference platform for the software in that repo, so 1.5.1.
DES
--
Dag-Erling Smørgrav - des@des.no
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2425668
Please start new threads on the <us...@subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <us...@subversion.apache.org>.
Re: Whitespace in svn:author
Posted by David Shere <ds...@steelerubber.com>.
Dag-Erling Smørgrav wrote:
> Is this (i.e. preserving whitespace in svn:author) intentional? If not,
> do more recent versions also preserve whitespace, or do they trim it?
I think a bigger question might be why and/or how the server accepted a
commit by such a user. I have tried to duplicate your problem by
creating users with leading spaces in their name. When I do, my commits
(and checkouts) fail with the message
"/home/david/tempRepo/conf/passwd:10: Option expected". This problem
magically goes away when I remove usernames with leading spaces from the
passwd file and restart the server daemon.
My server version is whatever version is the latest for Ubuntu Hardy
8.04 server.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2425658
Please start new threads on the <us...@subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <us...@subversion.apache.org>.