You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asyncband.apache.org by "QwQBiG (via GitHub)" <gi...@apache.org> on 2026/09/05 13:24:40 UTC

[PR] test(pool): cover cancellation during bounded acquisition [asyncband]

QwQBiG opened a new pull request, #286:
URL: https://github.com/apache/asyncband/pull/286

   ## Summary
   
   Motivated by reviewing OpenDAL's proposed Asyncband migration in apache/opendal#8219. Its [Memcached connection acquisition](https://github.com/apache/opendal/blob/a1387df5eea87ac446b5528381b113bbbc5053d7/core/services/memcached/src/core.rs#L191-L203) races `pool.get()` against a ten-second timeout, so an unfinished acquisition can be cancelled.
   
   Add bounded pool tests for cancellation:
   
   - while waiting for capacity;
   - after notification but before the acquisition is polled again;
   - during object creation, with another acquisition waiting.
   
   These complement the existing recycling and replenishment cancellation tests by checking acquisition cancellation through the public pool API. They verify waiter progress, capacity recovery, and object reuse.
   
   The tests use controlled polling without network calls or wall-clock timeouts. They check wake-driven progress without requiring FIFO notification order. Production code is unchanged; this is coverage for the existing cancellation contract, not a fix for an observed downstream failure.
   
   ## Validation
   
   - 23 pool integration tests passed on stable and Rust 1.86.
   - `cargo x test`: 476 tests and doctests passed.
   - Targeted Clippy, rustfmt, typos, and Hawkeye checks passed.
   
   Validation was performed locally in my WSL Linux.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org


Re: [PR] test(pool): cover cancellation during bounded acquisition [asyncband]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #286:
URL: https://github.com/apache/asyncband/pull/286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org


Re: [PR] test(pool): cover cancellation during bounded acquisition [asyncband]

Posted by "QwQBiG (via GitHub)" <gi...@apache.org>.
QwQBiG commented on PR #286:
URL: https://github.com/apache/asyncband/pull/286#issuecomment-5569205564

   > release train model where if a release failed, we start a new release from the new latest commit.
   
   Got it~ Thanks for the clarification and the merge~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org


Re: [PR] test(pool): cover cancellation during bounded acquisition [asyncband]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #286:
URL: https://github.com/apache/asyncband/pull/286#issuecomment-5566338380

   > can wait until after the 0.7.2 release.
   
   Need not to wait for release. I generally consider our release model as a release train model where if a release failed, we start a new release from the new latest commit.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org


Re: [PR] test(pool): cover cancellation during bounded acquisition [asyncband]

Posted by "QwQBiG (via GitHub)" <gi...@apache.org>.
QwQBiG commented on PR #286:
URL: https://github.com/apache/asyncband/pull/286#issuecomment-5552119186

   This is a non-blocking, test-only follow-up and can wait until after the 0.7.2 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org