You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li via Review Board <no...@reviews.apache.org> on 2018/01/18 18:18:48 UTC
Review Request 65224: SENTRY-2123: Specify Thrift source code path for
Javadoc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/
-----------------------------------------------------------
Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
Repository: sentry
Description
-------
add path for generated sentry thrift files
Diffs
-----
sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
sentry-provider/sentry-provider-db/pom.xml db4808d
Diff: https://reviews.apache.org/r/65224/diff/1/
Testing
-------
ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
Thanks,
Na Li
Re: Review Request 65224: SENTRY-2123: Specify Thrift source code
path for Javadoc
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/#review195829
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Jan. 19, 2018, 4:15 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65224/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2018, 4:15 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add path for generated sentry thrift files. And exclude generated thrift files for javadoc generation
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
> sentry-provider/sentry-provider-db/pom.xml db4808d
>
>
> Diff: https://reviews.apache.org/r/65224/diff/2/
>
>
> Testing
> -------
>
> ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 65224: SENTRY-2123: Specify Thrift source code
path for Javadoc
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/#review195830
-----------------------------------------------------------
Thanks Lina, I see that javadoc is excluding thrift auto-generated classes now. Could you change the subject of this review to reflect the new change?
- Sergio Pena
On Jan. 19, 2018, 4:15 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65224/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2018, 4:15 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add path for generated sentry thrift files. And exclude generated thrift files for javadoc generation
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
> sentry-provider/sentry-provider-db/pom.xml db4808d
>
>
> Diff: https://reviews.apache.org/r/65224/diff/2/
>
>
> Testing
> -------
>
> ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 65224: SENTRY-2123: Specify code path of
auth-generated
thrift files for Javadoc and exclude them from Javadoc generation
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/
-----------------------------------------------------------
(Updated Jan. 19, 2018, 4:46 p.m.)
Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
Summary (updated)
-----------------
SENTRY-2123: Specify code path of auth-generated thrift files for Javadoc and exclude them from Javadoc generation
Repository: sentry
Description
-------
add path for generated sentry thrift files. And exclude generated thrift files for javadoc generation
Diffs
-----
sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
sentry-provider/sentry-provider-db/pom.xml db4808d
Diff: https://reviews.apache.org/r/65224/diff/2/
Testing
-------
ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
Thanks,
Na Li
Re: Review Request 65224: SENTRY-2123: Specify Thrift source code
path for Javadoc
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/
-----------------------------------------------------------
(Updated Jan. 19, 2018, 4:15 p.m.)
Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
Repository: sentry
Description (updated)
-------
add path for generated sentry thrift files. And exclude generated thrift files for javadoc generation
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
sentry-provider/sentry-provider-db/pom.xml db4808d
Diff: https://reviews.apache.org/r/65224/diff/2/
Changes: https://reviews.apache.org/r/65224/diff/1-2/
Testing
-------
ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
Thanks,
Na Li
Re: Review Request 65224: SENTRY-2123: Specify Thrift source code
path for Javadoc
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/#review195755
-----------------------------------------------------------
Ship it!
Ship It!
- Arjun Mishra
On Jan. 18, 2018, 6:18 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65224/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 6:18 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add path for generated sentry thrift files
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
> sentry-provider/sentry-provider-db/pom.xml db4808d
>
>
> Diff: https://reviews.apache.org/r/65224/diff/1/
>
>
> Testing
> -------
>
> ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 65224: SENTRY-2123: Specify Thrift source code
path for Javadoc
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/#review195740
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Towles
On Jan. 18, 2018, 12:18 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65224/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 12:18 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add path for generated sentry thrift files
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/pom.xml 58719c3
> sentry-provider/sentry-provider-db/pom.xml db4808d
>
>
> Diff: https://reviews.apache.org/r/65224/diff/1/
>
>
> Testing
> -------
>
> ran build with javadoc plugin. Without this change, the javadoc build failed for sentry-provider-db and sentry-hdfs-common. With this change, the build succeeded
>
>
> Thanks,
>
> Na Li
>
>