You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by hanm <gi...@git.apache.org> on 2017/03/09 21:52:26 UTC
[GitHub] zookeeper pull request #187: ZOOKEEPER-2716: fix flaky test testAddSessionAf...
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/187
ZOOKEEPER-2716: fix flaky test testAddSessionAfterSessionExpiry.
We can't let the gate open until we increase the closed session count. Otherwise depends on timing, the test thread might see old session close count value between gate open and the session count actually gets increased.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2716
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit f16fe3a98718f3eb45812bd53b9afee96c76a589
Author: Michael Han <ha...@apache.org>
Date: 2017-03-09T21:51:36Z
ZOOKEEPER-2716: fix flaky test testAddSessionAfterSessionExpiry.
We can't let the gate open until we increase the closed session count. Otherwise depends on timing, the test thread might see old session
close count value between gate open and the session count actually gets increased.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #187: ZOOKEEPER-2716: fix flaky test testAddSessionAf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #187: ZOOKEEPER-2716: fix flaky test testAddSessionAfterSess...
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/187
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #187: ZOOKEEPER-2716: fix flaky test testAddSessionAfterSess...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/187
@rakeshadr any chance you can take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #187: ZOOKEEPER-2716: fix flaky test testAddSessionAfterSess...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/187
I think this is a fairly obvious one - anyone want to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---