[Impala-ASF-CR] IMPALA-14843: Show cancelled nodes in ExecSummary

["Jason Fehr (Code Review)" <ge...@cloudera.org>]

Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24118 )

Change subject: IMPALA-14843: Show cancelled nodes in ExecSummary
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24118/9/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

http://gerrit.cloudera.org:8080/#/c/24118/9/be/src/runtime/coordinator.cc@1808
PS9, Line 1808: (!stat.__isset.last_batch_returned || !stat.last_batch_returned)
> I am relatively new to this area, so I wanted to ask about how we handle ro
Good point.  The tradeoff is between query profile accuracy during rolling upgrades vs RPC size.  coordinator-backend-state.cc does not set last_batch_returned unless it has been returned.  This saves a few bytes in cases where the last batch hasn't been returned at the expense of possible query profile accuracy.  My view is the rolling upgrade situation is so unlikely that it's not worth increasing the RPC size.


http://gerrit.cloudera.org:8080/#/c/24118/3/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:

http://gerrit.cloudera.org:8080/#/c/24118/3/be/src/runtime/fragment-instance-state.cc@365
PS3, Line 365:         if (node->name().rfind(hash_type, 0) == 0
> That's a cleaner solution! Updated the patch for this part. Added a map fro
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24118
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd1bf51112e7c8c5609bb9e9525d960efc524215
Gerrit-Change-Number: 24118
Gerrit-PatchSet: 9
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2026 19:16:41 +0000
Gerrit-HasComments: Yes