You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/22 19:39:04 UTC
[GitHub] [pinot] jadami10 commented on a change in pull request #8369: [Generalized Pre-Aggregation] Initial Config wiring
jadami10 commented on a change in pull request #8369:
URL: https://github.com/apache/pinot/pull/8369#discussion_r832557231
##########
File path: pinot-spi/src/test/java/org/apache/pinot/spi/config/table/IndexingConfigTest.java
##########
@@ -38,6 +38,12 @@ public void testSerDe()
IndexingConfig indexingConfig = new IndexingConfig();
indexingConfig.setLoadMode("MMAP");
indexingConfig.setAggregateMetrics(true);
+ List<PreAggregationConfig> preAggregationConfigs =
+ Arrays.asList(
+ new PreAggregationConfig("c1", "SUM", "SUM_c1"),
+ new PreAggregationConfig("c2", "MIN", "MIN_c2"),
+ new PreAggregationConfig("c3", "MAX", "MAX_c2"));
Review comment:
these be double underscore, right? are we missing some validation that this isn't failing?
##########
File path: pinot-spi/src/test/java/org/apache/pinot/spi/config/table/IndexingConfigTest.java
##########
@@ -38,6 +38,12 @@ public void testSerDe()
IndexingConfig indexingConfig = new IndexingConfig();
indexingConfig.setLoadMode("MMAP");
indexingConfig.setAggregateMetrics(true);
+ List<PreAggregationConfig> preAggregationConfigs =
+ Arrays.asList(
+ new PreAggregationConfig("c1", "SUM", "SUM_c1"),
+ new PreAggregationConfig("c2", "MIN", "MIN_c2"),
+ new PreAggregationConfig("c3", "MAX", "MAX_c2"));
Review comment:
these should be double underscore, right? are we missing some validation that this isn't failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org