You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/04/11 10:14:12 UTC
[PR] Fix #11899: DefaultSettingsXmlFactory.write() always emits location comments [maven]
gnodet opened a new pull request, #11929:
URL: https://github.com/apache/maven/pull/11929
## Summary
- Fix `DefaultSettingsXmlFactory.write()` to default `addLocationInformation` to `false` and only enable it when an explicit `inputLocationFormatter` is provided via `XmlWriterRequest`, matching the existing behavior of `DefaultModelXmlFactory.write()`
- Apply the same fix to `DefaultToolchainsXmlFactory.write()` which had the identical bug
- Add tests verifying that location comments are suppressed by default and only emitted when a formatter is explicitly provided
Closes #11899
## Test plan
- [x] New `DefaultSettingsXmlFactoryTest` verifies no location comments without formatter
- [x] New `DefaultSettingsXmlFactoryTest` verifies location comments appear with explicit formatter
- [x] All 459 existing tests in `maven-impl` pass
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #11899: DefaultSettingsXmlFactory.write() always emits location comments [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #11929:
URL: https://github.com/apache/maven/pull/11929#issuecomment-4230902590
_Claude Code on behalf of Guillaume Nodet_
Closing in favor of #11924 which was raised first with the same fix for `DefaultSettingsXmlFactory`. Will submit the additional changes (toolchains fix + tests) as a PR to that branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #11899: DefaultSettingsXmlFactory.write() always emits location comments [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet closed pull request #11929: Fix #11899: DefaultSettingsXmlFactory.write() always emits location comments
URL: https://github.com/apache/maven/pull/11929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org