You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2016/01/30 02:35:20 UTC

Review Request 42995: [4 of 7] Allow tasks to set persistent volume as readonly or readwrite resource.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42995/
-----------------------------------------------------------

Review request for mesos and Adam B.


Bugs: MESOS-4324
    https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
-------

* If the task is the first consumer of the shared persistent volume, then
  set the ownership of the persistent volume to match that of the task.
  Otherwise, allow the task to be executed only if the ownership of the
  persistent volume matches that of the task.
* Allow the task to specify the persistent volume access to be read-only
  or read-write. Note that the persistent volume is always created as
  read-write.


Diffs
-----

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 24ff8194bb5ea86a31224d2d2c20d367472168aa 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp bce5ab9a1913ee7cebaf55b5ee0b42fa4a325e87 

Diff: https://reviews.apache.org/r/42995/diff/


Testing
-------

make check done.


Thanks,

Anindya Sinha


Re: Review Request 42995: Allow tasks to set persistent volume as readonly or readwrite resource.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42995/
-----------------------------------------------------------

(Updated Feb. 5, 2016, 10:57 p.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4324
    https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
-------

If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.


Diffs (updated)
-----

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp b9615becc87e6c69c5c56b6ae76ccae180c26917 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/42995/diff/


Testing
-------

make check done.


Thanks,

Anindya Sinha


Re: Review Request 42995: Allow tasks to set persistent volume as readonly or readwrite resource.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42995/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 12:38 a.m.)


Review request for mesos and Adam B.


Summary (updated)
-----------------

Allow tasks to set persistent volume as readonly or readwrite resource.


Bugs: MESOS-4324
    https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description (updated)
-------

If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.


Diffs (updated)
-----

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 24ff8194bb5ea86a31224d2d2c20d367472168aa 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp bce5ab9a1913ee7cebaf55b5ee0b42fa4a325e87 

Diff: https://reviews.apache.org/r/42995/diff/


Testing
-------

make check done.


Thanks,

Anindya Sinha