[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #2023: [NETBEANS-4021] - Support for Jakarta EE 8

[GitBox <gi...@apache.org>]

neilcsmith-net commented on a change in pull request #2023:
URL: https://github.com/apache/netbeans/pull/2023#discussion_r458158681



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
##########
@@ -45,6 +45,7 @@ enterprise/websvc.restlib/external/javax.annotation-api-1.2.jar java/maven.index
 enterprise/javaee.api/external/javax.annotation-api-1.2.jar java/maven.indexer/external/javax.annotation-api-1.2.jar
 enterprise/javaee7.api/external/javax.annotation-api-1.2.jar enterprise/javaee8.api/external/javax.annotation-api-1.2.jar
 enterprise/javaee8.api/external/javax.annotation-api-1.2.jar enterprise/websvc.restlib/external/javax.annotation-api-1.2.jar
+enterprise/jakartaee8.api/external/javax.annotation-api-1.3.5.jar

Review comment:
       This needs fixing before we can merge. It's causing the verify libs and licenses test to fail. Each line must contain two paths.  Is it meant to be a duplicate of something?  If so, needs to have the other path.  If not, then the whole line needs removing.
   
   Check with `ant verify-libs-and-licenses`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists