You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/05 15:57:37 UTC
[GitHub] [cordova-ios] msmtamburro opened a new pull request #1051: fix: reduce crashing, clarify documentation, and improve performance
msmtamburro opened a new pull request #1051:
URL: https://github.com/apache/cordova-ios/pull/1051
note: works around, rather than addresses existing architectural issues (#1031)
note: should be reviewed after merging this related PR https://github.com/apache/cordova-ios/pull/1050
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
cordova-ios
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
This is related to https://github.com/apache/cordova-ios/pull/1031, in that I noticed the existing looping/reflection pattern in CDVWebViewEngine was copied, and I wanted to provide an example of how to allow consumers to explicitly be delegates, so that pattern, which crashes, does not make its way in to other pieces of code.
### Description
<!-- Describe your changes in detail -->
The existing behavior, that CDVViewController can be a WKNavigationDelegate, was not obvious, so I documented it. While it would be more explicit to set the navigation delegate in the designated initializer (like is done with the WKWebViewConfiguration), I did not want to drastically change what's being done here. The existing behavior also loops through the plugins and uses reflection to see if any handle specific WKNavigationDelegate methods. The way this is done can crash (is crashing in my production app), as the list of plugins can change while this loop iterates.
What I did change:
- When a consumer has bothered to extend CDVViewController to be a WKNavigationDelegate, I've disabled the looping
- I cleaned up the looping to make it less likely to crash
### Testing
<!-- Please describe in detail how you tested your changes. -->
I've tested the existing behavior:
- Overriding does not disable looping
- Looping does not appear to crash
I've tested the new behavior:
- Looping is disabled when overriding (making CDVViewController a WKNavigationDelegate)
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on pull request #1051: fix: reduce crashing, clarify documentation, and improve performance
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1051:
URL: https://github.com/apache/cordova-ios/pull/1051#issuecomment-754793614
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=h1) Report
> Merging [#1051](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=desc) (10dd41b) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7e3402c565c2e34eae2bb954c65c989f71e20df1?el=desc) (7e3402c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1051 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 13 13
Lines 1720 1720
=======================================
Hits 1287 1287
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=footer). Last update [7e3402c...10dd41b](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1051: fix: reduce crashing, clarify documentation, and improve performance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1051:
URL: https://github.com/apache/cordova-ios/pull/1051#issuecomment-754793614
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=h1) Report
> Merging [#1051](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=desc) (0811908) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7e3402c565c2e34eae2bb954c65c989f71e20df1?el=desc) (7e3402c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1051 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 13 13
Lines 1720 1720
=======================================
Hits 1287 1287
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=footer). Last update [7e3402c...0811908](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1051: fix: reduce crashing, clarify documentation, and improve performance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1051:
URL: https://github.com/apache/cordova-ios/pull/1051#issuecomment-754793614
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=h1) Report
> Merging [#1051](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=desc) (10dd41b) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7e3402c565c2e34eae2bb954c65c989f71e20df1?el=desc) (7e3402c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1051 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 13 13
Lines 1720 1720
=======================================
Hits 1287 1287
Misses 433 433
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=footer). Last update [7e3402c...9f86588](https://codecov.io/gh/apache/cordova-ios/pull/1051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org