You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/11 14:22:34 UTC

[GitHub] [incubator-seatunnel] tmljob opened a new pull request, #1685: [Bug][seatunnel-common]-Fix common path problem(#1683)

tmljob opened a new pull request, #1685:
URL: https://github.com/apache/incubator-seatunnel/pull/1685

<!--

Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

## Contribution Checklist

- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).

- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.

- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.

-->

## Purpose of this pull request

## Check list

* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/development/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1685: [Bug][seatunnel-common]Fix Windows environment file address get error

Posted by GitBox <gi...@apache.org>.

ruanwenjun commented on PR #1685:
URL: https://github.com/apache/incubator-seatunnel/pull/1685#issuecomment-1099789050

   Thanks for your patch, we need to add Windows environment on our CI, #1697 will cover this PR. I will close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun closed pull request #1685: [Bug][seatunnel-common]Fix Windows environment file address get error

Posted by GitBox <gi...@apache.org>.

ruanwenjun closed pull request #1685: [Bug][seatunnel-common]Fix Windows environment file address get error
URL: https://github.com/apache/incubator-seatunnel/pull/1685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1685: [Bug][seatunnel-common]-Fix common path problem(#1683)

Posted by GitBox <gi...@apache.org>.

BenJFan commented on code in PR #1685:
URL: https://github.com/apache/incubator-seatunnel/pull/1685#discussion_r847985179


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java:
##########
@@ -57,16 +58,13 @@ public static Optional<String> getDeployMode() {
     }
 
     /**
-     * Root dir varies between different spark master and deploy mode,
-     * it also varies between relative and absolute path.
-     * When running seatunnel in --master local, you can put plugins related files in $project_dir/plugins,
-     * then these files will be automatically copied to $project_dir/seatunnel-core/target and token in effect if you start seatunnel in IDE tools such as IDEA.
-     * When running seatunnel in --master yarn or --master mesos, you can put plugins related files in plugins dir.
+     * Root dir varies between different spark master and deploy mode, it also varies between relative and absolute path. When running seatunnel in --master local, you can put plugins related files in $project_dir/plugins, then these files will be automatically copied to $project_dir/seatunnel-core/target and token in effect if you start seatunnel in IDE tools such as IDEA. When running seatunnel in --master yarn or --master mesos, you can put plugins related files in plugins dir.

Review Comment:
   Single line comment should not be too long



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1685: [Bug][seatunnel-common]-Fix common path problem(#1683)

Posted by GitBox <gi...@apache.org>.

ruanwenjun commented on PR #1685:
URL: https://github.com/apache/incubator-seatunnel/pull/1685#issuecomment-1095244983

   Maybe we need to add `Windows` environment to run UT in CI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org