You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/14 01:16:37 UTC
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10330: Add create readwrite splitting rule
tristaZero commented on a change in pull request #10330:
URL: https://github.com/apache/shardingsphere/pull/10330#discussion_r632200000
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/antlr4/imports/Keyword.g4
##########
@@ -82,7 +82,23 @@ FROM
SHARDING
: S H A R D I N G
;
-
+
+READ_WRITE_SPLITTING
Review comment:
```yaml
rules:
- !READWRITE_SPLITTING
```
shows us `readwrite_spliting`, is it better to keep the same keyword here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org