You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by zhengruifeng <gi...@git.apache.org> on 2017/12/05 07:21:42 UTC

[GitHub] spark pull request #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

GitHub user zhengruifeng opened a pull request:

    https://github.com/apache/spark/pull/19889

    [SPARK-22690][ML] Imputer inherit HasOutputCols

    ## What changes were proposed in this pull request?
    make `Imputer` inherit `HasOutputCols`
    
    ## How was this patch tested?
    existing tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhengruifeng/spark using_HasOutputCols

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19889
    
----
commit 5881b88cfcee0989ef5e715ce4e243b501b39ec7
Author: Zheng RuiFeng <ru...@foxmail.com>
Date:   2017-12-05T07:16:32Z

    create pr

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    **[Test build #84459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84459/testReport)** for PR 19889 at commit [`5881b88`](https://github.com/apache/spark/commit/5881b88cfcee0989ef5e715ce4e243b501b39ec7).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by holdenk <gi...@git.apache.org>.

Github user holdenk commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    LGTM pending Jenkins.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84459/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84468/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by zhengruifeng <gi...@git.apache.org>.

Github user zhengruifeng commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84462/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    **[Test build #84459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84459/testReport)** for PR 19889 at commit [`5881b88`](https://github.com/apache/spark/commit/5881b88cfcee0989ef5e715ce4e243b501b39ec7).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by zhengruifeng <gi...@git.apache.org>.

Github user zhengruifeng commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by zhengruifeng <gi...@git.apache.org>.

Github user zhengruifeng commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    No other algs output multi-column for now


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    **[Test build #84468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84468/testReport)** for PR 19889 at commit [`5881b88`](https://github.com/apache/spark/commit/5881b88cfcee0989ef5e715ce4e243b501b39ec7).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    LGTM thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19889
  
    **[Test build #84462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84462/testReport)** for PR 19889 at commit [`5881b88`](https://github.com/apache/spark/commit/5881b88cfcee0989ef5e715ce4e243b501b39ec7).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org