You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by kwmonroe <gi...@git.apache.org> on 2016/11/07 19:24:44 UTC
[GitHub] bigtop pull request #157: BIGTOP-2577: kafka charm test updates
GitHub user kwmonroe opened a pull request:
https://github.com/apache/bigtop/pull/157
BIGTOP-2577: kafka charm test updates
Similar updates to what we did for the zk charm (BIGTOP-2575). Update the Juju charm for Kafka:
- update readme with language consistent with other bigtop charms
- ensure we deploy correct kafka charm and watch for correct status during tests
- use new syntax for executing smoke tests
- include the network interface binding test (previously skipped)
- report the application version for status output
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juju-solutions/bigtop bug/k-cwr-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit a02922859b69ec53f4c86debee0d5f29e1e1f7fa
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-10-29T19:06:38Z
use bigtop and xenial charms in tests; use new action syntax; update nic test to be like the (better) one in the zookeeper charm
commit 869ec1aa0add53c30366c300f3d32b0671919ca6
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-10-29T19:16:45Z
update readme to be consistent with other bigtop charms
commit 6d2d593be57d056964f07d12034447aa2ccfa5cf
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-11-07T18:59:08Z
add app version for juju status output
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #157: BIGTOP-2577: kafka charm test updates
Posted by petevg <gi...@git.apache.org>.
Github user petevg commented on the issue:
https://github.com/apache/bigtop/pull/157
Tests work for me, and code looks good. LGTM/+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #157: BIGTOP-2577: kafka charm test updates
Posted by petevg <gi...@git.apache.org>.
Github user petevg commented on the issue:
https://github.com/apache/bigtop/pull/157
My charms having been addressed, I am +1 on this one :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #157: BIGTOP-2577: kafka charm test updates
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/157
Good catch in zookeeper -- you suggested the better approach of relaxing the charm definition in the test.. Most recent commit should address your concerns. Thanks @petevg!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #157: BIGTOP-2577: kafka charm test updates
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bigtop/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---