You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/03/31 00:40:21 UTC
[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
Tim Armstrong has abandoned this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
......................................................................
Abandoned
Abandoning for now since there wasn't a consensus about it and I don't have time right now to push it forward. I think we should consider going forward with it even if some of it will be superseded by other mechanisms because it provides immediate performance benefits by inlining CpuInfo::IsSupported() and speeding up the interpreted path.
--
To view, visit http://gerrit.cloudera.org:8080/3843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6ba029ed8589698eb15dbfb0a20dd2a7ea752635
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>