[GitHub] [iceberg] CircArgs commented on a diff in pull request #4816: remove operations from base expressions; add in expression

[GitBox <gi...@apache.org>]

CircArgs commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r889186036


##########
python/src/iceberg/expressions/base.py:
##########
@@ -285,6 +270,9 @@ def __str__(self):
     def __repr__(self):
         return f"BoundReference(field={repr(self.field)}, accessor={repr(self._accessor)})"
 
+    def __eq__(self, other) -> bool:

Review Comment:
   changed to dataclasses 



##########
python/src/iceberg/expressions/base.py:
##########
@@ -267,6 +227,31 @@ def __str__(self) -> str:
         return "false"
 
 
+@dataclass
+class UnboundIn(BooleanExpression, UnboundPredicate):

Review Comment:
   updated this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org