[GitHub] [zookeeper] ztzg edited a comment on pull request #934: ZOOKEEPER-3301:Enforce the quota limit

[GitBox <gi...@apache.org>]

ztzg edited a comment on pull request #934:
URL: https://github.com/apache/zookeeper/pull/934#issuecomment-715887848


   > @ztzg You overrate me(feel an obligation to do it). We still leave some other works about quota in the future, please join it.
   
   Sorry! My goal was not to "push" you at all—quite the opposite. You have already done a huge amount of work on this, and I don't think GitHub's workflows are sufficient here.
   
   As far as I know, there is no easy way for multiple people to contribute to a PR, besides reviews and comments. But those could still be useful if, for example, subsets of the patch are difficult to "rebase"; I would gladly take care of some of the files and "ship" the results to you if that helps.
   
   But okay, I'll keep quiet from now on—unless, of course, you decide to take me up on the offer :)
   
   (And yes, I am also planning to look into this and other topics in the future.)
   
   > > To make quota enforcement effective. I think,
   > 
   > @arshadmohammad Yes, I really think about the permission issue in the original github description(maybe we can take an example from what we have done for `/zookeeper/config`). I will not do it in this PR to make it bigger. Please create another ticket to do it.
   
   Right.  I 100% agree with @arshadmohammad's suggestion of the feature (and using `/zookeeper/config` as a guide), but I also 100% think it should be done later on.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org