You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/30 19:19:40 UTC
Review Request 23172: Fix build breakage caused by string append syntax
failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23172/
-----------------------------------------------------------
Review request for mesos, Isabel Jimenez and Vinod Kone.
Repository: mesos-git
Description
-------
build was failing due to attempt to append int to string.
Diffs
-----
src/credentials/credentials.hpp c446aec721029b559989ce22e18438f56077bc39
Diff: https://reviews.apache.org/r/23172/diff/
Testing
-------
build succeeds.
Thanks,
Dominic Hamon
Re: Review Request 23172: Fix build breakage caused by string append syntax
failure
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23172/#review47017
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 30, 2014, 5:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23172/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> build was failing due to attempt to append int to string.
>
>
> Diffs
> -----
>
> src/credentials/credentials.hpp c446aec721029b559989ce22e18438f56077bc39
>
> Diff: https://reviews.apache.org/r/23172/diff/
>
>
> Testing
> -------
>
> build succeeds.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 23172: Fix build breakage caused by string append syntax
failure
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23172/#review47002
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23172]
All tests passed.
- Mesos ReviewBot
On June 30, 2014, 5:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23172/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> build was failing due to attempt to append int to string.
>
>
> Diffs
> -----
>
> src/credentials/credentials.hpp c446aec721029b559989ce22e18438f56077bc39
>
> Diff: https://reviews.apache.org/r/23172/diff/
>
>
> Testing
> -------
>
> build succeeds.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 23172: Fix build breakage caused by string append syntax
failure
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23172/#review46994
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On June 30, 2014, 5:19 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23172/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 5:19 p.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> build was failing due to attempt to append int to string.
>
>
> Diffs
> -----
>
> src/credentials/credentials.hpp c446aec721029b559989ce22e18438f56077bc39
>
> Diff: https://reviews.apache.org/r/23172/diff/
>
>
> Testing
> -------
>
> build succeeds.
>
>
> Thanks,
>
> Dominic Hamon
>
>