You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/09 13:27:35 UTC

[GitHub] [tvm] Lunderberg commented on pull request #8960: [Hexagon] Add contrib tests for blocked conv2d and maxpool2d

Lunderberg commented on pull request #8960:
URL: https://github.com/apache/tvm/pull/8960#issuecomment-916091088


   The changes look good to me.  I like the hoisting of the shape definitions up into the `conftest.py`, to avoid redefinition across multiple files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org