[GitHub] [arrow] nevi-me commented on a change in pull request #8449: ARROW-7842: [Rust] [Parquet] Arrow list reader

[GitBox <gi...@apache.org>]

nevi-me commented on a change in pull request #8449:
URL: https://github.com/apache/arrow/pull/8449#discussion_r503551927



##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -1049,9 +1049,7 @@ mod tests {
     }
 
     #[test]
-    #[should_panic(
-        expected = "Reading parquet list array into arrow is not supported yet!"
-    )]
+    #[ignore = "Roundtrip failing, reason likely reader, not yet investigated"]

Review comment:
       @carols10cents when you can, may you please help me out here on these 2 tests that I've ignored?
   One needs a `LargeList` writer implementation, which I think you'd do better than me as you've done roundtrip for other Arrow types.
   
   I've unignored `struct_single_column` as it's now passing, might be the null comparison commit that fixed it.
   
   Thanks :smiley:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org