[GitHub] [iotdb] HTHou commented on a change in pull request #2605: Add level merge to "merge" command

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #2605:
URL: https://github.com/apache/iotdb/pull/2605#discussion_r579584630



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/manage/MergeManager.java
##########
@@ -252,8 +252,7 @@ public ServiceType getID() {
 
   private void mergeAll() {
     try {
-      StorageEngine.getInstance()
-          .mergeAll(IoTDBDescriptor.getInstance().getConfig().isForceFullMerge());
+      StorageEngine.getInstance().mergeAll(IoTDBDescriptor.getInstance().getConfig().isForceFullMerge());

Review comment:
       ```suggestion
         StorageEngine.getInstance()
             .mergeAll(IoTDBDescriptor.getInstance().getConfig().isForceFullMerge());
   ```

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1940,19 +1940,26 @@ private void closeUnsealedTsFileProcessorCallBack(TsFileProcessor tsFileProcesso
         "signal closing storage group condition in {}",
         logicalStorageGroupName + "-" + virtualStorageGroupId);
 
+    executeCompaction(
+        tsFileProcessor.getTimeRangeId(),
+        IoTDBDescriptor.getInstance().getConfig().isForceFullMerge());
+  }
+
+  private void executeCompaction(long timePartition, boolean fullMerge){

Review comment:
       ```suggestion
     private void executeCompaction(long timePartition, boolean fullMerge) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org