You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/10/25 17:27:12 UTC

[jira] [Commented] (BOOKKEEPER-425) Cleanup Bookie id generation

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484190#comment-13484190 ] 

Flavio Junqueira commented on BOOKKEEPER-425:
---------------------------------------------

The patch does not apply cleanly to trunk. Bookie.java and AutoRecoveryMain.java have conflicts. Do you want me to fix the conflicts, Ivan?
                
> Cleanup Bookie id generation
> ----------------------------
>
>                 Key: BOOKKEEPER-425
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-425
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-425.diff
>
>
> Bookie id generation (InetAddress.getLocalHost().getHostAddress() + ":" + port) is scattered all over the place. It would be better to have it centrallized somewhere in a static call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira