You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by shahidki31 <gi...@git.apache.org> on 2018/11/18 23:12:49 UTC

[GitHub] spark pull request #23081: [SPARK-26109][WebUI]Duration in the task summary ...

GitHub user shahidki31 opened a pull request:

    https://github.com/apache/spark/pull/23081

    [SPARK-26109][WebUI]Duration in the task summary metrics table and the task table are different

    ## What changes were proposed in this pull request?
    Task summary displays the summary of the task table in the stage page. However, the duration metrics of task summary and task table are not matching. The reason is because, in the task summary we display executorRunTime as the duration and in task table, the actual duration.
    Except duration metrics, all other metrics are properly displaying in the task summary.
    
    In Spark2.2, we used to show executorRunTime as duration in the taskTable. That is why, in summary metrics also the exeuctorRunTime shows as the duration. In Spark2.3, it changed to the actual duration of task. So, summary metrics also should change according to that.
    
    ## How was this patch tested?
    Before patch:
    
    ![screenshot from 2018-11-19 04-32-06](https://user-images.githubusercontent.com/23054875/48679263-1e4fff80-ebb4-11e8-9ed5-16d892039e01.png)
    
    After patch:
    ![screenshot from 2018-11-19 04-37-39](https://user-images.githubusercontent.com/23054875/48679343-e39a9700-ebb4-11e8-8df9-9dc3a28d4bce.png)
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shahidki31/spark duratinSummary

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23081
    
----
commit 131164c2104a119468e782fb1d484f2d15274e33
Author: Shahid <sh...@...>
Date:   2018-11-18T22:38:21Z

    taskMetrics duration

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by shahidki31 <gi...@git.apache.org>.

Github user shahidki31 commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    Thank you @srowen 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    **[Test build #98984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98984/testReport)** for PR 23081 at commit [`131164c`](https://github.com/apache/spark/commit/131164c2104a119468e782fb1d484f2d15274e33).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23081
  
    **[Test build #99052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99052/testReport)** for PR 23081 at commit [`97bd213`](https://github.com/apache/spark/commit/97bd213b085a1b1fd264156bd1f090d673d603f4).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org