You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "David Keen (Created) (JIRA)" <ji...@apache.org> on 2012/01/12 03:37:40 UTC
[jira] [Created] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Form.getSection(Component) to return the section for nested components
----------------------------------------------------------------------
Key: PIVOT-834
URL: https://issues.apache.org/jira/browse/PIVOT-834
Project: Pivot
Issue Type: New Feature
Components: wtk
Affects Versions: 2.0, 2.0.1
Reporter: David Keen
Priority: Minor
Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483074#comment-13483074 ]
Sandro Martini commented on PIVOT-834:
--------------------------------------
To me the patch seems Ok, so unless objections I'd say to commit in 2.0.x (and as usual even in trunk), and reassign this to 2.0.3 .
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
> Reporter: David Keen
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.4
>
> Attachments: pivot-834.patch
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini reassigned PIVOT-834:
------------------------------------
Assignee: Sandro Martini
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2
> Reporter: David Keen
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.3
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-834:
---------------------------------
Affects Version/s: 2.0.3
Fix Version/s: (was: 2.0.3)
2.0.4
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
> Reporter: David Keen
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.4
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482513#comment-13482513 ]
Roger Whitcomb commented on PIVOT-834:
--------------------------------------
In looking into this change, there are some subtle implications to changing the existing method:
1) TerraFormSkin uses Form.getSection() in conjunction with section.indexOf() in the "labelChanged" method. This probably would break badly with the proposed change, and the follow-on changes to "getIndex" and etc. would quickly get to be very confusing.
2) As someone noted this is easy enough to implement in an application by following the parent chain.
So, I would propose adding another method: "Form.getEnclosingSection(Component)" that would do what is requested for when it is needed, but leave the existing method alone.
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
> Reporter: David Keen
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.4
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Sandro Martini (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-834:
---------------------------------
Fix Version/s: 2.0.2
Some info here:
http://apache-pivot-users.399431.n3.nabble.com/Form-getSection-returns-null-for-nested-components-td3643647.html
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1
> Reporter: David Keen
> Priority: Minor
> Fix For: 2.0.2
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb resolved PIVOT-834.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.0.4)
2.0.3
[trunk]
Sending wtk\src\org\apache\pivot\wtk\Form.java
Transmitting file data .
Committed revision 1401781.
[branches/2.0.x]
Sending .
Sending wtk\src\org\apache\pivot\wtk\Form.java
Transmitting file data .
Committed revision 1401783.
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
> Reporter: David Keen
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.3
>
> Attachments: pivot-834.patch
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb reassigned PIVOT-834:
------------------------------------
Assignee: Roger Whitcomb (was: Sandro Martini)
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
> Reporter: David Keen
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.0.4
>
> Attachments: pivot-834.patch
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-834:
---------------------------------
Affects Version/s: 2.0.2
Fix Version/s: (was: 2.0.2)
2.0.3
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2
> Reporter: David Keen
> Priority: Minor
> Fix For: 2.0.3
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-834) Form.getSection(Component) to return
the section for nested components
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-834:
---------------------------------
Attachment: pivot-834.patch
The "pivot-834.patch" file implements my suggestion (no change to "getSection", add a new "getEnclosingSection" method). Adds Javadoc to explain what each does.
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
> Key: PIVOT-834
> URL: https://issues.apache.org/jira/browse/PIVOT-834
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
> Reporter: David Keen
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.4
>
> Attachments: pivot-834.patch
>
>
> Form.getSection returns the Form.Section of the given component. However, it currently only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components of a form, regardless of whether they are nested or not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira