[GitHub] [spark] Yikun commented on a diff in pull request #36368: [WIP][K8S] Support Pod template placeholder

[GitBox <gi...@apache.org>]

Yikun commented on code in PR #36368:
URL: https://github.com/apache/spark/pull/36368#discussion_r859473314


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala:
##########
@@ -102,7 +104,8 @@ object KubernetesUtils extends Logging {
       val hadoopConf = SparkHadoopUtil.get.newConfiguration(conf)
       val localFile = downloadFile(templateFileName, Utils.createTempDir(), conf, hadoopConf)
       val templateFile = new File(new java.net.URI(localFile).getPath)
-      val pod = kubernetesClient.pods().load(templateFile).get()
+      val podTemplateString = Files.toString(templateFile, StandardCharsets.UTF_8)
+      val pod = kubernetesClient.pods().load(podTemplateString).get()

Review Comment:
   oops, I just wanted to submit a PR in my local repo to see the test result. Sorry for noise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org