You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "ranqiqiang (Jira)" <ji...@apache.org> on 2022/04/14 02:28:00 UTC

[jira] [Commented] (FLINK-17826) Add missing custom query support on new jdbc connector

    [ https://issues.apache.org/jira/browse/FLINK-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522019#comment-17522019 ] 

ranqiqiang commented on FLINK-17826:
------------------------------------

We have also implemented a similar function, remember that the community did not agree before, and now agree, ready to merge into 1.15 1.16?  [~leonard]

> Add missing custom query support on new jdbc connector
> ------------------------------------------------------
>
>                 Key: FLINK-17826
>                 URL: https://issues.apache.org/jira/browse/FLINK-17826
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / JDBC
>            Reporter: Jark Wu
>            Priority: Minor
>              Labels: auto-deprioritized-major, auto-unassigned, pull-request-available
>             Fix For: 1.16.0
>
>
> In FLINK-17361, we added custom query on JDBC tables, but missing to add the same ability on new jdbc connector (i.e. {{JdbcDynamicTableSourceSinkFactory}}). 
> In the new jdbc connector, maybe we should call it {{scan.query}} to keep consistent with other scan options, besides we need to make {{"table-name"}} optional, but add validation that "table-name" and "scan.query" shouldn't both be empty, and "table-name" must not be empty when used as sink.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)