[jira] [Commented] (SOLR-17859) TimeLimitingBulkScorer not used anymore for queries with limits

["Chris M. Hostetter (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-17859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018875#comment-18018875 ] 

Chris M. Hostetter commented on SOLR-17859:
-------------------------------------------

PR looks good to me.

> TimeLimitingBulkScorer not used anymore for queries with limits
> ---------------------------------------------------------------
>
>                 Key: SOLR-17859
>                 URL: https://issues.apache.org/jira/browse/SOLR-17859
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: main (10.0)
>            Reporter: Andrzej Bialecki
>            Assignee: Andrzej Bialecki
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> After Lucene 10 upgrade (SOLR-17631) it's very likely that query limits are not enforced in this collector, due to the Lucene API change and the commented-out method in {{SolrIndexSearcher.search(List<LeafReaderContext> leaves, Weight weight, Collector collector)}}.
> Unfortunately there were no unit tests in Solr to specifically target this code execution path - the existing tests related to {{QueryLimits}} are either too synthetic or simulate timeouts in other components.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org