You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2024/03/22 01:43:21 UTC
[PR] Rename function name to `add_manifests` [iceberg-rust]
viirya opened a new pull request, #293:
URL: https://github.com/apache/iceberg-rust/pull/293
While I'm looking into #286, I found there is one function `add_manifest_entries` which is confusing to me.
In fact, it writes manifest instead of manifest entries. As I think manifest entries (i.e., `ManifestEntry`) should refer to the entries inside manifest (i.e., `Manifest`). I think updating the function names and a few comments make it less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Rename function name to `add_manifests` [iceberg-rust]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #293:
URL: https://github.com/apache/iceberg-rust/pull/293#issuecomment-2015167742
Thank you @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Rename function name to `add_manifests` [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #293:
URL: https://github.com/apache/iceberg-rust/pull/293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org