You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/07/01 02:14:18 UTC
Re: Review Request 35799: Support mounting relative paths with docker.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/
-----------------------------------------------------------
(Updated July 1, 2015, 12:14 a.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
Bugs: MESOS-2374
https://issues.apache.org/jira/browse/MESOS-2374
Repository: mesos
Description
-------
Support mounting relative paths with docker.
Diffs (updated)
-----
src/docker/docker.cpp 62aac2773d8b74e19619cf593064165892b03ba6
src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c
Diff: https://reviews.apache.org/r/35799/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 35799: Support mounting relative paths with docker.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review90006
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35799]
All tests passed.
- Mesos ReviewBot
On July 1, 2015, 12:14 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35799/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-2374
> https://issues.apache.org/jira/browse/MESOS-2374
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Support mounting relative paths with docker.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 62aac2773d8b74e19619cf593064165892b03ba6
> src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c
>
> Diff: https://reviews.apache.org/r/35799/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 35799: Support mounting relative paths with docker.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review90040
-----------------------------------------------------------
Ship it!
Looks good - just a few minor const. suggestions :)
src/tests/docker_tests.cpp (line 75)
<https://reviews.apache.org/r/35799/#comment142977>
Why not const?
src/tests/docker_tests.cpp (line 250)
<https://reviews.apache.org/r/35799/#comment142978>
Const?
src/tests/docker_tests.cpp (line 365)
<https://reviews.apache.org/r/35799/#comment142980>
Const?
src/tests/docker_tests.cpp (line 391)
<https://reviews.apache.org/r/35799/#comment142979>
Const?
- Till Toenshoff
On July 1, 2015, 12:14 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35799/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-2374
> https://issues.apache.org/jira/browse/MESOS-2374
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Support mounting relative paths with docker.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 62aac2773d8b74e19619cf593064165892b03ba6
> src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c
>
> Diff: https://reviews.apache.org/r/35799/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>