[GitHub] [cordova-osx] giuseppelt opened a new pull request #85: set public CDVWindowSizeCommand.h

[GitBox <gi...@apache.org>]

giuseppelt opened a new pull request #85: set public CDVWindowSizeCommand.h
URL: https://github.com/apache/cordova-osx/pull/85
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   OSX
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Actually plugins can not use cordova resize funcions, because they're not "exported". Thus plugin can not leverage the work of cordova framework.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   To use cordova window resize functions, the command must be public, that is, callable by plugins. This change just make accessible the header.
   
   Example of a plugin:
   ```swift
   #import <Cordova/CDVWindowSizeCommand.h> // <--- to import the header must be public
   
   - (void) makeFullscreen: (CDVInvokedUrlCommand *)command {
       BOOL fullscreen = [[command argumentAtIndex:0] boolValue];
   
       NSWindow* window = self.webView.window;
       if (fullscreen == NO) {
           [CDVWindowSizeCommand removeFullScreen:window];
       } else {
           [CDVWindowSizeCommand makeFullScreen:window];
       }
       
       [self.commandDelegate sendPluginResult:[CDVPluginResult resultWithStatus:CDVCommandStatus_OK] callbackId:command.callbackId];
   }
   
   ```
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   No test needed
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org